Skip to content

Mark UseDSP Features as false for default / unsupported devices#1155

Merged
anhappdev merged 10 commits into
masterfrom
mohit/updateDefaultCase
Jun 24, 2026
Merged

Mark UseDSP Features as false for default / unsupported devices#1155
anhappdev merged 10 commits into
masterfrom
mohit/updateDefaultCase

Conversation

@mohitmundhragithub

Copy link
Copy Markdown
Contributor

No description provided.

@mohitmundhragithub mohitmundhragithub requested review from a team and anhappdev as code owners June 9, 2026 14:07
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@mohitmundhragithub

Copy link
Copy Markdown
Contributor Author

@anhappdev can we merge it?

anhappdev
anhappdev previously approved these changes Jun 16, 2026
freedomtan
freedomtan previously approved these changes Jun 16, 2026

@freedomtan freedomtan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this. @anhappdev please prepare another release to the Play Store. Let's make it 6.0.1.

@anhappdev

Copy link
Copy Markdown
Collaborator

@mohitmundhragithub Unfortunately, the test still failed. The CI runs in two steps. In step 1, the APK is built, and one device for each backend is tested. When step 1 succeeds, then step 2 runs with extended devices set. To make it quicker to catch failed tests, I will move the S23 Ultra to step 1.

@anhappdev anhappdev dismissed stale reviews from freedomtan and themself via feb302d June 16, 2026 06:09
@mohitmundhragithub

Copy link
Copy Markdown
Contributor Author

06-16 07:18:12.053 E/TestRunner(23418): java.lang.Exception: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
06-16 07:18:12.053 E/TestRunner(23418): The following TestFailure was thrown running a test:
06-16 07:18:12.053 E/TestRunner(23418): Expected:
06-16 07:18:12.053 E/TestRunner(23418): Actual:
06-16 07:18:12.053 E/TestRunner(23418): Progress screen is not presented
06-16 07:18:12.053 E/TestRunner(23418):

Getting above error from S26 ultra. May be some issue in browserstack.

The error in S23 Ultra, I don't see that in my personal S23 Ultra. Is there something wrong in the browser stack device?
How are the other SD8Gen2 devices that were failing earlier are passing now? like Galaxy Tab S9 etc.

@anhappdev

Copy link
Copy Markdown
Collaborator

@mohitmundhragithub some performance tests are flaky and the numbers was just lower than expected, a rerun should solve it.
For S23 you can find the log in the CI summary page.

@mohitmundhragithub

Copy link
Copy Markdown
Contributor Author

@mohitmundhragithub some performance tests are flaky and the numbers was just lower than expected, a rerun should solve it. For S23 you can find the log in the CI summary page.

I am not sure how to resolve the S23 Ultra issue. The issue is not reproducible on my personal phone.
In the rerun, i see the same error message from the logs for S23 ultra.
Is there a way to find the OS version on Browser stack device for S23 ultra?

@mohitmundhragithub

Copy link
Copy Markdown
Contributor Author

ran the new apk again on my phone.Screenshot_20260616_154314.jpg

@anhappdev

Copy link
Copy Markdown
Collaborator

Is there a way to find the OS version on Browser stack device for S23 ultra?

You can find the OS version in the name of the run. It is 13.0 for S23 Ultra.

@mohitmundhragithub

Copy link
Copy Markdown
Contributor Author

Is there a way to find the OS version on Browser stack device for S23 ultra?

You can find the OS version in the name of the run. It is 13.0 for S23 Ultra.

my phone is on Android version 16. Any way to ask them to update it?

@anh-ng

anh-ng commented Jun 16, 2026

Copy link
Copy Markdown

Is there a way to find the OS version on Browser stack device for S23 ultra?

You can find the OS version in the name of the run. It is 13.0 for S23 Ultra.

my phone is on Android version 16. Any way to ask them to update it?

I don’t think it’s possible. Our option is just remove this device from CI test.

@mohitmundhragithub

Copy link
Copy Markdown
Contributor Author

So, the app is still crashing on both Galaxy S23 and Galaxy Tab S9. But in our local devices, as well as my personal phone (galaxy s23 ultra), we are unable to reproduce the issue.
Seems like the issue is because of the Android version... I can't think of anything else, why the test case would fail for OD, but pass for ICV2.

I think we we can remove these old devices for now, and meanwhile, if possible, ask browserstack to update these devices?

@mohitmundhragithub

mohitmundhragithub commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

seems like galaxy S24 has some issues with browserstack... @anhappdev can you please check?

https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

@mohitmundhragithub

Copy link
Copy Markdown
Contributor Author

@anhappdev can you please check?

@anhappdev

Copy link
Copy Markdown
Collaborator

@mohitmundhragithub I fixed the issue with node version in this PR #1157. After merging it into master we can update this branch.

@sonarqubecloud

Copy link
Copy Markdown

@mohitmundhragithub

Copy link
Copy Markdown
Contributor Author

@freedomtan @anh-ng can we merge this now?

@anhappdev

Copy link
Copy Markdown
Collaborator

@freedomtan @anh-ng can we merge this now?

Yes, should be good to merge, please approve. I made the last commit so I cannot approve the PR.

@freedomtan freedomtan self-requested a review June 24, 2026 13:39
@anhappdev anhappdev merged commit b9cff1e into master Jun 24, 2026
49 of 52 checks passed
@anhappdev anhappdev deleted the mohit/updateDefaultCase branch June 24, 2026 15:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants