Skip to content

Security v1.0.1 definition#1539

Merged
superdosh merged 7 commits into
mainfrom
register-security-v1
Jun 18, 2026
Merged

Security v1.0.1 definition#1539
superdosh merged 7 commits into
mainfrom
register-security-v1

Conversation

@superdosh

Copy link
Copy Markdown
Contributor

Also make future version updates easier.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@superdosh superdosh temporarily deployed to Scheduled Testing June 17, 2026 17:51 — with GitHub Actions Inactive
@superdosh superdosh marked this pull request as ready for review June 17, 2026 17:52
@superdosh superdosh requested a review from a team as a code owner June 17, 2026 17:52
Comment thread src/modelgauge/annotators/cheval/ids.py Outdated

@bkorycki bkorycki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version constants are nice! that will make it much easier to make version updates in the future.

Comment thread src/modelbench/cli.py
Comment thread src/modelgauge/annotators/cheval/ids.py Outdated
@superdosh superdosh temporarily deployed to Scheduled Testing June 17, 2026 19:10 — with GitHub Actions Inactive
@superdosh superdosh temporarily deployed to Scheduled Testing June 17, 2026 20:11 — with GitHub Actions Inactive
@superdosh superdosh requested a review from bkorycki June 17, 2026 20:12

@bkorycki bkorycki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks

@rogthefrog rogthefrog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

SAFETY_ANNOTATOR_V1_1_UID = "safety-v1.1"
from modelgauge.versions import CURRENT_GENERAL_VERSION, CURRENT_SECURITY_VERSION

SAFETY_ANNOTATOR_V1_1_UID = f"safety-v{CURRENT_GENERAL_VERSION}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!


SAFETY_ANNOTATOR_V1_1_UID = f"safety-v{CURRENT_GENERAL_VERSION}"
SECURITY_ANNOTATOR_V0_5_UID = "security-v0.5"
SECURITY_ANNOTATOR_V1_0_1_UID = f"security-v{CURRENT_SECURITY_VERSION}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this!

Comment thread src/modelbench/hazards.py
from pydantic import BaseModel, ConfigDict

from modelgauge.versions import (
CURRENT_GENERAL_V_UNDER,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@superdosh superdosh merged commit 5dbc78b into main Jun 18, 2026
3 checks passed
@superdosh superdosh deleted the register-security-v1 branch June 18, 2026 12:21
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants