Skip to content

catch all bugs #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkorycki merged 3 commits into from
Jun 22, 2026
Merged

catch all bugs #1547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e58aafc
catch all bugs
bkorycki Jun 22, 2026
4582030
update test
bkorycki Jun 22, 2026
59a447a
black
bkorycki Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/modelgauge/annotators/composer/dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,14 +268,14 @@ def _run_traced(self, ctx: EvalContext) -> tuple[SuccessfulDAGOutput | FailedDAG
for node_name in self._ordered:
if node_name not in reachable:
continue
ctx = ctx.with_parent_outputs(
{pred: node_outputs[pred] for pred in self._predecessors[node_name] if pred in node_outputs}
)
node = self._nodes[node_name]
try:
ctx = ctx.with_parent_outputs(
{pred: node_outputs[pred] for pred in self._predecessors[node_name] if pred in node_outputs}
)
node = self._nodes[node_name]
output = self._run_node(node, ctx)
except Exception as e:
wrapped_error = NodeExecutionError(node.name, e)
wrapped_error = NodeExecutionError(node_name, e)
return (
FailedDAGOutput(
node_outputs=node_outputs,
Expand Down
9 changes: 3 additions & 6 deletions tests/modelgauge_tests/annotator_tests/composer_tests/test_composer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

from modelgauge.annotators.composed_annotator import Safety
from modelgauge.annotators.composer.context import EvalContext
from modelgauge.annotators.composer.dag import Composer, ComposerColumnNames
from modelgauge.annotators.composer.dag import Composer, ComposerColumnNames, FailedDAGOutput


def test_dag_outputs(simple_dag):
Expand Down Expand Up @@ -274,11 +274,8 @@ def test_dag_parallel_nodes_different_updated_contexts_raises_error():
.add_node(LowerCaseScorer(name="lower_scorer", routes=["threshold_arbiter"]))
.add_node(ThresholdArbiter(name="threshold_arbiter", threshold=0.5))
)
with pytest.raises(
ValueError,
match="all parent outputs must have the same updated prompt/response",
):
dag.run(ctx)
result = dag.run(ctx)
assert isinstance(result, FailedDAGOutput)


def test_dag_run_with_dataframe_json_md(simple_dag):
Expand Down
Loading