Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ZeevRispler
suggested changes
Apr 2, 2024
Contributor
ZeevRispler
left a comment
ZeevRispler
left a comment
There was a problem hiding this comment.
seems like most code is similar to the other training function, i belive there is a good way to make this a lot shorter
guy1992l
reviewed
Apr 9, 2024
| @@ -0,0 +1,23 @@ | |||
| apiVersion: v1 | |||
| categories: | |||
Member
There was a problem hiding this comment.
@yonishelach please advise what category to add for GenAI.
Contributor
There was a problem hiding this comment.
Add these exact categories:
genaihuggingfaceNLP
yonishelach
suggested changes
Apr 9, 2024
| @@ -0,0 +1,23 @@ | |||
| apiVersion: v1 | |||
| categories: | |||
Contributor
There was a problem hiding this comment.
Add these exact categories:
genaihuggingfaceNLP
Contributor
|
@pengwei715 also your CI test is failing, so need to resolve this issue as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @guy1992l @ZeevRispler @yonishelach
I have followed your work of auto_trainer to implement the dpo trainer. Please review and let me know.
Thanks