Onnx_utils remove plotly dependency#875
Open
daniels290813 wants to merge 1 commit intomlrun:development-archive-20250928from
Open
Onnx_utils remove plotly dependency#875daniels290813 wants to merge 1 commit intomlrun:development-archive-20250928from
daniels290813 wants to merge 1 commit intomlrun:development-archive-20250928from
Conversation
Member
Eyal-Danieli
left a comment
Eyal-Danieli
left a comment
There was a problem hiding this comment.
@daniels290813 it seems that plotly is being used in the tests. That means we can't remove it, but we need to adjust the ver in order to resolve https://iguazio.atlassian.net/browse/FHUB-90. If you’re not sure which version is needed, I think @guy1992l can help clarify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://iguazio.atlassian.net/browse/FHUB-90