Open
Conversation
mlsdpk
requested changes
Jun 23, 2025
Owner
mlsdpk
left a comment
mlsdpk
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks good overall. Just a few minor changes are needed and we're good to go.
Comment on lines
+6
to
15
| # Fix DNS or HTTP-related fetch issues first | ||
| RUN find /etc/apt/sources.list.d -name "*.list" -exec sed -i 's|http://deb.debian.org|https://deb.debian.org|g' {} + && \ | ||
| apt-get update && \ | ||
| apt-get install -y curl ca-certificates && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Install Python | ||
| RUN apt-get update && \ | ||
| apt-get install -y python3 python3-pip python3-venv && \ | ||
| rm -rf /var/lib/apt/lists/* |
Owner
There was a problem hiding this comment.
we could consider reducing our image layers by combining these two installation steps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the mirror URLs from http to https in files under /etc/apt/sources.list.d/ (since /etc/apt/sources.list doesn’t exist).
Installed curl and ca-certificates first to avoid network-related issues.
Re-ordered and split some steps for better reliability and clarity.