Widen Nintendo BLE discovery + scan diagnostics + in-menu errors (v1.2.2) - #12
Merged
Conversation
…2.2) Field report follow-up: scans run clean for 30 s but never see the controller, and error notifications are invisible in run-from-source. - Match both Nintendo company IDs in manufacturer data: 0x0553 (the actual Bluetooth SIG assigned ID, used by other Switch 2 community tools) and 0x057E (Nintendo's USB VID, matched previously). A controller advertising 0x0553 with no device name was undetectable. - When a scan round finds nothing, log every device seen (name, rssi, manufacturer data hex, capped at 20) — turns "not found" reports into actionable data. - Show the last connection error in the dropdown while idle (⚠️ line): rumps notifications don't show when running from source, so failures were completely silent in the UI. - Tests: discovery filter matrix (0x0553 / 0x057E / name fallback / unrelated device) — 56 bridge checks Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up on the Reddit field report: permissions are fine, the 30 s search runs clean, but the controller is never matched — and the user saw no error because rumps notifications are invisible in run-from-source.
0x0553(Nintendo's actual Bluetooth SIG ID, used by other Switch 2 community tools) in addition to0x057E(Nintendo's USB VID). A controller advertising0x0553with no name was previously undetectable.Test plan
🤖 Generated with Claude Code