Self-review hardening: reconnect error spam, DSU toggle safety (v1.2.3) - #13
Merged
Conversation
Second-pass review of the v1.2.2 changes found:
- Failing reconnect attempts during the 60s auto-reconnect window each
surfaced a "Connection failed" notification while the app was still
retrying — now only the final give-up message is shown, attempts stay
in the logs
- The DSU menubar toggle rewrote mappings.json with defaults when the
file was corrupt, clobbering a user-authored (fixable) file — it now
refuses to persist and keeps the toggle in memory only
- Cosmetic: unify the connected detail line format between _apply_state
and the tick ("pkts")
Also verified in this pass: pyflakes clean on all files; rumps APIs used
(alert ok/cancel return codes, set_callback(None) disabling, MenuItem
.state) confirmed against the installed library source.
Tests: reconnect-spam scenario (drop + failing reconnects → no error
until give-up), corrupt-file toggle safety — 62 bridge checks.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to a « are you sure there are no bugs? » pass over v1.2.2.
Found & fixed:
mappings.jsonwith defaults. It now refuses to persist rather than clobber.Verified clean in the same pass: pyflakes on all files; rumps API contracts (
alertreturn codes,set_callback(None),MenuItem.state) checked against the installed library source;_tick/_idle_noteordering; DSU socket lifecycle races.Tests: two new regression scenarios (62 bridge + 50 DSU checks green, CI on this PR).
🤖 Generated with Claude Code