Skip to content

Improve conflicting Lua feature errors - #730

Open
oiahoon wants to merge 1 commit into
mlua-rs:mainfrom
oiahoon:fix/conflicting-feature-error
Open

Improve conflicting Lua feature errors#730
oiahoon wants to merge 1 commit into
mlua-rs:mainfrom
oiahoon:fix/conflicting-feature-error

Conversation

@oiahoon

@oiahoon oiahoon commented Aug 17, 2026

Copy link
Copy Markdown

Summary

  • report the Lua runtime features that are actually enabled when they conflict
  • keep luajit52 concise instead of also listing its implied luajit feature
  • preserve the existing single-feature and no-feature behavior

Verification

  • cargo check -p mlua-sys --features lua51,lua54 --offline (expected failure names both features)
  • cargo check -p mlua-sys --features lua55,lua53,luau --offline (expected failure names all three features)
  • cargo check -p mlua-sys --features lua54,luajit52 --offline (expected failure names luajit52 once)
  • cargo check -p mlua-sys --features lua54,vendored --offline
  • cargo test --features lua54,vendored --offline
  • cargo clippy -p mlua-sys --all-targets --features lua54,vendored --offline -- -D warnings
  • rustfmt --edition 2024 --check mlua-sys/build/main.rs

Closes #729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error message

1 participant