Improve conflicting Lua feature errors - #730
Open
oiahoon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
luajit52concise instead of also listing its impliedluajitfeatureVerification
cargo check -p mlua-sys --features lua51,lua54 --offline(expected failure names both features)cargo check -p mlua-sys --features lua55,lua53,luau --offline(expected failure names all three features)cargo check -p mlua-sys --features lua54,luajit52 --offline(expected failure namesluajit52once)cargo check -p mlua-sys --features lua54,vendored --offlinecargo test --features lua54,vendored --offlinecargo clippy -p mlua-sys --all-targets --features lua54,vendored --offline -- -D warningsrustfmt --edition 2024 --check mlua-sys/build/main.rsCloses #729