Don't pin objects permanently in ast.c#90
Merged
d-netto merged 4 commits intommtk-support-moving-upstreamfrom Jun 21, 2025
Merged
Don't pin objects permanently in ast.c#90d-netto merged 4 commits intommtk-support-moving-upstreamfrom
d-netto merged 4 commits intommtk-support-moving-upstreamfrom
Conversation
d-netto
force-pushed
the
dcn-optimize-pinning-in-ast
branch
from
b67cb36 to
1dc1459
Compare
d-netto
changed the title
qinsoon
approved these changes
Jun 21, 2025
Member
qinsoon
left a comment
qinsoon
left a comment
There was a problem hiding this comment.
LGTM. Nice refactoring.
Did you run the evaluation again with this PR? I am just interested to get an idea of what we would expect from this PR on the benchmark.
Collaborator
Author
|
I did. I shared a fragmentation time-series and a pinning profile on Slack, but the conclusion is that, with this PR, our fragmentation is still around 100MB, but we no longer have pins coming from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jl_value_t*s passed tojulia_to_scm_will now be pushed into a per-AST-context vector and pinned/unpinned at the end of GC.The per-AST-context vector of pinned objects is reset when we de-allocate its corresponding AST context.