Trace pinned objects as roots#91
Merged
qinsoon merged 2 commits intommtk:mmtk-support-moving-upstreamfrom Jun 27, 2025
Merged
Conversation
d-netto
reviewed
Jun 24, 2025
Collaborator
d-netto
left a comment
d-netto
left a comment
There was a problem hiding this comment.
Functionally, this looks fine.
I was wondering whether we should rename pinned_objects. The name seems a bit misleading since they are basically roots now.
Member
Author
d-netto
approved these changes
Jun 26, 2025
Collaborator
d-netto
left a comment
d-netto
left a comment
There was a problem hiding this comment.
LGTM. Before merging this PR, please make sure you're able to build Julia with it, and that it doesn't degrade fragmentation or runtime in the inference benchmark.
Ditto. |
udesou
approved these changes
Jun 26, 2025
Member
Author
|
Fragmentation and performance is similar as before. |
udesou
pushed a commit
to udesou/julia
that referenced
this pull request
Jul 30, 2025
Following the suggestion in mmtk#89 (comment), trace recently added pinned objects as roots. When we pass those objects as 'nodes' to MMTk, MMTk does not know the slots so MMTk cannot update the reference, thus MMTk will not move those objects. This is essentially the same as pinning those objects before a GC, and unpinning after a GC.
udesou
pushed a commit
to udesou/julia
that referenced
this pull request
Aug 1, 2025
Following the suggestion in mmtk#89 (comment), trace recently added pinned objects as roots. When we pass those objects as 'nodes' to MMTk, MMTk does not know the slots so MMTk cannot update the reference, thus MMTk will not move those objects. This is essentially the same as pinning those objects before a GC, and unpinning after a GC.
udesou
pushed a commit
to udesou/julia
that referenced
this pull request
Aug 5, 2025
Following the suggestion in mmtk#89 (comment), trace recently added pinned objects as roots. When we pass those objects as 'nodes' to MMTk, MMTk does not know the slots so MMTk cannot update the reference, thus MMTk will not move those objects. This is essentially the same as pinning those objects before a GC, and unpinning after a GC.
qinsoon
added a commit
that referenced
this pull request
Feb 9, 2026
Following the suggestion in #89 (comment), trace recently added pinned objects as roots. When we pass those objects as 'nodes' to MMTk, MMTk does not know the slots so MMTk cannot update the reference, thus MMTk will not move those objects. This is essentially the same as pinning those objects before a GC, and unpinning after a GC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the suggestion in #89 (comment), trace recently added pinned objects as roots. When we pass those objects as 'nodes' to MMTk, MMTk does not know the slots so MMTk cannot update the reference, thus MMTk will not move those objects. This is essentially the same as pinning those objects before a GC, and unpinning after a GC.