Skip to content

fix: return all eligible FIFO partition jobs per sweep instead of one #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mnbuhl wants to merge 4 commits into from
Closed

fix: return all eligible FIFO partition jobs per sweep instead of one #18

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6e49d2
fix: return all eligible FIFO partition jobs per sweep instead of one
mnbuhl May 4, 2026
5e5852a
refactor: remove narrating comments from EF Core LINQ fallback
mnbuhl May 4, 2026
883aa26
test: widen flaky grace-period timing upper bound to 2.5s
mnbuhl May 4, 2026
e1c471b
revert: restore one-job-per-partition FIFO semantics
mnbuhl May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/Atomizer.Tests/Processing/QueuePumpTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,12 @@ public async Task StopAsync_WhenWorkerIsLongRunning_ShouldRespectGracePeriod()
await pump.StopAsync(TimeSpan.FromSeconds(1), CancellationToken.None);
sw.Stop();

// Assert: Should return after about 1 second, not 2
// Assert: Should return after the grace period (1s), well before the worker finishes (3s)
sw.Elapsed.TotalSeconds.Should().BeGreaterThanOrEqualTo(1);
sw.Elapsed.TotalSeconds.Should()
.BeLessThanOrEqualTo(
1.5,
$"StopAsync should return after about 1 second, elapsed: {sw.Elapsed.TotalSeconds}"
.BeLessThan(
2.5,
$"StopAsync should return after the grace period, not wait for the worker, elapsed: {sw.Elapsed.TotalSeconds}"
);

logger.Received(1).LogInformation($"Stopping queue '{queueOptions.QueueKey}'...");
Expand Down
Loading