chore: Drop unsupported EF Core provider fallback#19
Merged
Conversation
Remove the unsafe EF Core fallback path so the storage backend has a single explicit provider contract: SQL Server, PostgreSQL, and MySQL. Unsupported providers now fail during storage construction instead of partially working through LINQ fallback paths. Constraint: Public API breakage was explicitly approved in the PRD Constraint: SQLite is retained only as a narrow fail-fast regression test dependency Rejected: Keep internal SQLite fallback for tests | would preserve unsupported provider behavior Rejected: Method-level unsupported checks | provider-neutral methods could remain accidentally usable Confidence: high Scope-risk: moderate Directive: Do not reintroduce unsupported-provider fallback paths without adding a supported SQL dialect and contract tests Tested: csharpier check . Tested: dotnet build Tested: dotnet test tests/Atomizer.EntityFrameworkCore.Tests/Atomizer.EntityFrameworkCore.Tests.csproj -f net8.0 Tested: dotnet test tests/Atomizer.EntityFrameworkCore.Tests/Atomizer.EntityFrameworkCore.Tests.csproj -f net10.0 Not-tested: net6.0 test execution; Microsoft.NETCore.App 6.0 runtime is not installed locally
|
mnbuhl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the unsupported EF Core provider fallback path so
Atomizer.EntityFrameworkCoreonly supports SQL Server, PostgreSQL, and MySQL.What changed
AllowUnsafeProviderFallbackoption.Oracle,Sqlite,Unknown).Impact
This is an intentional breaking change for consumers relying on unsupported providers or the fallback option. Supported SQL Server, PostgreSQL, and MySQL paths remain covered.