fix(build): pin EF Core major per TFM to avoid net10 binary break#9
Merged
fix(build): pin EF Core major per TFM to avoid net10 binary break#9
Conversation
Consumers on .NET 10 hit MissingMethodException on
IRelationalCommandBuilder.Append(string) because the provider assemblies
were compiled against EF 8 (floor [8.0.0, )), where Append has a single
string parameter. EF 9/10 added a second bool parameter on the interface
method, so the IL emitted against EF 8 no longer resolves at runtime.
Each library and test project now multi-targets net8.0/net9.0/net10.0 and
pins the EF package version to the matching major via per-TFM ItemGroups
(or VersionOverride for CPM-enabled test projects). The compiled
assembly shipped for net{N}.0 is therefore built against EF {N}.x,
matching its runtime.
Pomelo.EntityFrameworkCore.MySql has no net10.0 build yet, so the MySql
provider, its tests, and the benchmarks cap at net9.0. The test-mysql CI
matrix is trimmed to 8.0/9.0 to match.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MissingMethodException: IRelationalCommandBuilder.Append(string)on .NET 10 consumers. The provider assemblies were compiled against EF 8 (floor[8.0.0, )), whereAppendhas a single string parameter; EF 9/10 added a secondbool endOfLineparameter on the interface method, so the IL emitted against EF 8 no longer resolves at runtime.net8.0;net9.0;net10.0and pins the EF package version per TFM (bounded[N.0.0, {N+1}.0.0)ranges, orVersionOverridefor CPM-enabled test projects). Thenet{N}.0assembly shipped in the nupkg is therefore compiled against EF{N}.x, matching its runtime.Pomelo.EntityFrameworkCore.MySqlhas nonet10.0build yet, so the MySql provider, its tests, and the benchmarks cap atnet9.0. Thetest-mysqlCI matrix trims to8.0.x/9.0.xto match.