Skip to content

Remove test_io_set_preload_false_is_faster #13933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbrnr wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −21
Open

Remove test_io_set_preload_false_is_faster #13933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b1d18c
Remove test_io_set_preload_false_is_faster
cbrnr May 29, 2026
82a311c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions mne/io/eeglab/tests/test_eeglab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import os
import shutil
import time
from copy import deepcopy

import numpy as np
Expand Down Expand Up @@ -768,26 +767,6 @@ def test_eeglab_drop_nan_annotations(tmp_path):
raw = read_raw_eeglab(file_path, preload=True)


@pytest.mark.flaky
@testing.requires_testing_data
@pytest.mark.timeout(10)
@pytest.mark.slowtest # has the advantage of not running on macOS where it errs a lot
def test_io_set_preload_false_is_faster():
"""Using preload=False should skip the expensive data read branch."""
# warm start
read_raw_eeglab(raw_fname_mat, preload=False)

durations = {}
for preload in (True, False):
start = time.perf_counter()
_ = read_raw_eeglab(raw_fname_mat, preload=preload)
durations[preload] = time.perf_counter() - start

# preload=True should not be faster than preload=False (timings may vary
# across systems, so avoid strict thresholds)
assert durations[True] > durations[False]


@testing.requires_testing_data
def test_lazy_vs_preload_integrity():
"""Test that lazy loading produces identical data to preload."""
Expand Down
Loading