Skip to content

chore: misc fixes #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mneverov merged 2 commits into from
Mar 12, 2026
Merged

chore: misc fixes #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d8a072
Print lock names when expected != actual.
mneverov Mar 12, 2026
ce68f7b
Return early when found field by name.
mneverov Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions protectedby/analyzer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,18 +430,15 @@ func getLock(pass *analysis.Pass, spec *ast.TypeSpec, c *ast.Comment) (*ast.Fiel
}

func getStructFieldByName(name string, st *ast.StructType) *ast.Field {
var lockField *ast.Field

for _, field := range st.Fields.List {
for _, n := range field.Names {
if name == n.Name {
lockField = field
break
return field
}
}
}

return lockField
return nil
}

// getLockName returns the first word in the comment after "protected by" statement or error if the statement is not
Expand Down
2 changes: 1 addition & 1 deletion protectedby/analyzer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func Test_getLockName(t *testing.T) {
}

if name != tc.expectedLockName {
t.Fatalf("expected lock name %q, got %q", tc.expectedError, err)
t.Fatalf("expected lock name %q, got %q", tc.expectedLockName, name)
}
})
}
Expand Down
Loading