Normalize OpenCode Go MPS model IDs - #2020
Open
guillaumegay13 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2020 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 182 182
Lines 16939 16944 +5
Branches 6705 6706 +1
=======================================
+ Hits 16826 16831 +5
Misses 111 111
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
guillaumegay13
marked this pull request as ready for review
May 25, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencode-go/<model-id>route model strings against bare modelparams.dev catalog model IDs for OpenCode Go.Why
The modelparams.dev catalog cannot store slash-delimited model IDs. The companion catalog PR adds
provider: opencode-go,model: mimo-v2.5, but Manifest discovers/routes OpenCode Go models asopencode-go/mimo-v2.5. Without this normalization, the catalog row exists but the app cannot load it for the routed model.Companion catalog PR: mnfst/modelparams.dev#32
Validation
npm cinpm --workspace packages/shared test -- provider-params-spec.spec.tsnpm --workspace packages/shared run buildnpm --workspace packages/backend test -- model-params.controller.spec.ts proxy.service.spec.ts proxy-fallback.service.spec.tsnpx eslint packages/shared/src/provider-params-spec.tsgit diff --checkSummary by cubic
Normalize OpenCode Go model IDs so routed IDs like
opencode-go/mimo-v2.5match the catalog’s bare model IDs and load configurable params correctly. Route identities remain unchanged.opencode-go/prefix during spec lookup to match modelparams.dev entries.Written for commit 11c3aa6. Summary will update on new commits. Review in cubic