Skip to content

Normalize OpenCode Go MPS model IDs - #2020

Open
guillaumegay13 wants to merge 1 commit into
mnfst:mainfrom
guillaumegay13:fix/opencode-go-mps-model-normalization
Open

Normalize OpenCode Go MPS model IDs#2020
guillaumegay13 wants to merge 1 commit into
mnfst:mainfrom
guillaumegay13:fix/opencode-go-mps-model-normalization

Conversation

@guillaumegay13

@guillaumegay13 guillaumegay13 commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Match opencode-go/<model-id> route model strings against bare modelparams.dev catalog model IDs for OpenCode Go.
  • Keep saved route identities unchanged, so existing per-route params remain scoped to the actual Manifest route.
  • Add a patch changeset and a focused shared regression test.

Why

The modelparams.dev catalog cannot store slash-delimited model IDs. The companion catalog PR adds provider: opencode-go, model: mimo-v2.5, but Manifest discovers/routes OpenCode Go models as opencode-go/mimo-v2.5. Without this normalization, the catalog row exists but the app cannot load it for the routed model.

Companion catalog PR: mnfst/modelparams.dev#32

Validation

  • npm ci
  • npm --workspace packages/shared test -- provider-params-spec.spec.ts
  • npm --workspace packages/shared run build
  • npm --workspace packages/backend test -- model-params.controller.spec.ts proxy.service.spec.ts proxy-fallback.service.spec.ts
  • npx eslint packages/shared/src/provider-params-spec.ts
  • git diff --check

Summary by cubic

Normalize OpenCode Go model IDs so routed IDs like opencode-go/mimo-v2.5 match the catalog’s bare model IDs and load configurable params correctly. Route identities remain unchanged.

  • Bug Fixes
    • Strip the opencode-go/ prefix during spec lookup to match modelparams.dev entries.
    • Preserve saved route IDs so per-route params stay scoped to the actual Manifest route.
    • Added a focused regression test and a patch changeset.

Written for commit 11c3aa6. Summary will update on new commits. Review in cubic

@codecov

codecov Bot commented May 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.33%. Comparing base (ef76530) to head (11c3aa6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2020   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files         182      182           
  Lines       16939    16944    +5     
  Branches     6705     6706    +1     
=======================================
+ Hits        16826    16831    +5     
  Misses        111      111           
  Partials        2        2           
Flag Coverage Δ
frontend 99.37% <ø> (ø)
shared 97.79% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guillaumegay13
guillaumegay13 marked this pull request as ready for review May 25, 2026 14:11

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant