Fix the mutation setting of hierarchy-inert commands#3232
Open
Fishbowler wants to merge 1 commit intomainfrom
Open
Fix the mutation setting of hierarchy-inert commands#3232Fishbowler wants to merge 1 commit intomainfrom
Fishbowler wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Performance improvement.
Maestro performs assertions like assertNotVisible based on a timer tied to the last command that altered the hierarchy. We track that through a return value on a command that indicates whether the command mutated the hierarchy (or may have).
This change updates a few inert commands, marking them as non-mutating, which will speed up assertions that immediately follow them.
In the below example, assertNotVisible's timer should be from the tapOn, not from the last copyTextFrom.
I've added comments on justifications, so that the next person visiting this code might be able to think a little less about these :)
Testing
e2e 🤞
Issues fixed
Fixes #3117