Warn when deprecated --android-api-level / --ios-version flags are used#3262
Open
Warn when deprecated --android-api-level / --ios-version flags are used#3262
Conversation
Print a runtime warning pointing users to --device-os when either flag is passed to maestro cloud. Previously the flags were marked deprecated and hidden from help, but used silently with no feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--android-api-leveland--ios-versiononmaestro cloudare marked@Deprecatedand hidden from--help, but were silently accepted with no user-facing feedback. This adds a runtime warning that points users to--device-os.Test plan
maestro cloud --android-api-level=33 ...prints the deprecation warningmaestro cloud --ios-version=17.0 ...prints the deprecation warning