Implement AsyncNetworkableError with localization and CustomNSError #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NOTB4D
commented
Jan 30, 2026
NOTB4D
commented
- Add AsyncNetworkableError with localized descriptions and CustomNSError bridging to preserve domain/code/userInfo.
- Replace NSError throws in AsyncNetworkable+Data with enum-based errors, including httpError(statusCode:data:) for non-2xx responses.
- Improve response logging by including HTTP status text.
- Add localized strings for new network error keys in en.lproj and tr.lproj.
- Remove LocalizedDescriptionKey in favor of enum-backed localization.
…ridging, replace NSError throws in AsyncNetworkable+Data, add HTTP status to response logs, and add localized strings for network error keys. Add AsyncNetworkableError with localized descriptions and CustomNSError bridging to preserve domain/code/userInfo. Replace NSError throws in AsyncNetworkable+Data with enum-based errors, including httpError(statusCode:data:) for non-2xx responses. Improve response logging by including HTTP status text. Add localized strings for new network error keys in en.lproj and tr.lproj.
Contributor
|
@NOTB4D eline sağlık. buraya daha okunaklı log'lar ekleme planım var. onu yapınca beraber çıkacağım. güzel başlangıç oldu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.