dockerfile: fix heredoc parsing with space after modifier#6822
Open
kasperk81 wants to merge 1 commit into
Open
dockerfile: fix heredoc parsing with space after modifier#6822kasperk81 wants to merge 1 commit into
kasperk81 wants to merge 1 commit into
Conversation
Signed-off-by: kasperk81 <83082615+kasperk81@users.noreply.github.com>
Author
|
this works FROM alpine:3.22
RUN cat <<-EOF > /hello.txt
hello
EOF
RUN cat /hello.txtthis too: FROM alpine:3.22
RUN cat << EOF > /hello.txt
hello
EOF
RUN cat /hello.txtbut this was failing with FROM alpine:3.22
RUN cat <<- EOF > /hello.txt
hello
EOF
RUN cat /hello.txt |
Member
Both of those are expected to fail, because there's no Dockerfile here-doc used, so they're line-terminated; This is the Dockerfile RUN cat << EOF > /hello.txtAnd |
thaJeztah
requested changes
Jun 2, 2026
thaJeztah
left a comment
Member
There was a problem hiding this comment.
This doesn't look correct (see my comment); it's conflating here-docs used in a shell with here-docs provided by the Dockerfile parser.
Author
they both work, do you mean that's a bug that they aren't failing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this case: #5778 (comment)