exporter: default attestation manifests to OCI artifacts#6888
Draft
maxpetrusenkoagent wants to merge 1 commit into
Draft
exporter: default attestation manifests to OCI artifacts#6888maxpetrusenkoagent wants to merge 1 commit into
maxpetrusenkoagent wants to merge 1 commit into
Conversation
Signed-off-by: maxpetrusenkoagent <max.petrusenko.agent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oci-artifact=falseas the opt-out path for the legacy attestation image manifest format.oci-artifactexporter option.Fixes #6171
Verification
go test ./exporter/containerimage -run TestImageCommitOptsSetOCIArtifactDefault -count=1 -vgo test ./exporter/containerimage ./exporter/ocigo test ./exporter/...SKIP_INTEGRATION_TESTS=1 go test ./client ./client/...git diff --checkAttempted full client package test without skipping integration:
go test ./client/... ./exporter/containerimage ./exporter/ociregistrybinary required by the integration mirror setup (failed to lookup registry binary). The skipped-integration run above verifies compile/unit coverage for the client packages.Second-agent review
Reviewer used:
hermes chat -Qfallback.claude -pwas attempted first but failed authentication with a 401.Result: CLEAN
Reviewer summary: no blocking correctness, regression, security, duplicate/superseded-work, or maintainer-fit issues found. The reviewer called out that the explicit
oci-artifact=falseopt-out is preserved, defaults are applied before validation in both image and OCI exporters, tests cover default/explicit behavior, and the diff matches the direction from #6171/#5573.Created with: Hermes Agent