Merged
Conversation
Signed-off-by: Andrew Breja <andrew.breja@docker.com>
Signed-off-by: David Scott <dave@recoil.org>
andrewb-ontheinternet
force-pushed
the
update-go-dependencies
branch
from
4397252 to
03ff6c5
Compare
Collaborator
|
Builds locally for me, the GHA build succeeded but a post-build action failed. I think I can look at that separately. |
Collaborator
|
Thanks! |
djs55
added a commit
to djs55/vpnkit
that referenced
this pull request
Dec 8, 2025
Update the crazy-max/.github reusable workflow to the latest version to fix a JSON parsing error that occurs when PR metadata contains control characters (like newlines in the PR body). The previous version (d9a10e2) used actions/github-script@v7 which had an issue where it embedded the GitHub event payload directly into a JavaScript template literal containing JSON. When JSON.parse() encountered unescaped control characters, it would fail with: SyntaxError: Bad control character in string literal in JSON at position... The newer version (387d336) uses actions/github-script@v8 which handles JSON serialization more properly, preventing these parsing errors. Fixes the build failure seen in PR moby#654. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
djs55
added a commit
to djs55/vpnkit
that referenced
this pull request
Dec 8, 2025
Update the crazy-max/.github reusable workflow to the latest version to fix a JSON parsing error that occurs when PR metadata contains control characters (like newlines in the PR body). The previous version (d9a10e2) used actions/github-script@v7 which had an issue where it embedded the GitHub event payload directly into a JavaScript template literal containing JSON. When JSON.parse() encountered unescaped control characters, it would fail with: SyntaxError: Bad control character in string literal in JSON at position... The newer version (387d336) uses actions/github-script@v8 which handles JSON serialization more properly, preventing these parsing errors. Fixes the build failure seen in PR moby#654. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: David Scott <dave@recoil.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Go dependencies to address CVEs. Mainly focused on refreshing the K8s desktop-vpnkit-controller image.
I tried to follow the previous version bump PR: #635
Let me know if I need to do anything else, thanks!