BUGFIX: Generate unique uriPathSegment if target segment already exists

[sbruggmann]

Given you name a new or existing page the same as another page is named already..
you end up with two different nodes which have the identical uriPathSegment and only one is accessible.

A real world example was, where a client had a hideInMenu node named "News" with the actual news document childnodes in it.
And then the client created a Shortcut named "News" with target to the home.

An alternative but outdated implementation you find in #2
Would be great to see this fixed 👍

[aertmann]

Hey thanks for the bugfix! I wonder why this is necessary, Neos already has handling of this internally.

See https://github.com/neos/neos-development-collection/blob/master/Neos.Neos/Classes/Utility/NodeUriPathSegmentGenerator.php#L43-L56, triggered by https://github.com/neos/neos-development-collection/blob/5a7129fde94f8d423753699208be55d8b452d2af/Neos.Neos/Classes/Package.php#L92-L102

So I wonder why this is not happening when$node->setProperty('uriPathSegment', $newUriPathSegment); is called.

Would you be up for looking into why that's the case? Maybe we need to call that method ourselves after setProperty for it to work.

[sbruggmann]

Hm, true.. I take a look at it 👍

[aertmann]

ping @sbruggmann

[sbruggmann]

Big sorry for the delay! @aertmann

You're right. NodeUriPathSegmentGenerator::setUniqueUriPathSegment($node); should get called via nodePropertyChanged.

The nodePropertyChanged Signal is fired for the setProperty('title', ..), but with the setProperty('uriPathSegment', ..) of this package nothing happens.
I currently don't see what's the problem. Looks like something deeper in Flow maybe..?