-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/mod 223 implement geometry notations to mod dlm #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lukasfuh
merged 7 commits into
develop
from
feature/mod-223-implement-geometry-notations-to-mod-dlm
Mar 4, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2802a36
replaced boundingboxSchema with GeometrySchema
73f47b3
renamed to boundingboxschema
c47b006
added new boundingbox schema
ce6eb3a
extended DimensionalAttributesSchema
ac4f8d0
removed linebreak
c408113
Ûpdated comments and added description
6fafcc8
updated boundingbox schema
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,19 @@ | ||
| import { z } from "zod"; | ||
|
|
||
| const BoundingBoxSchema = z.object({ | ||
| width: z.number().gt(0, "Width must be greater than 0"), | ||
| height: z.number().gt(0, "Height must be greater than 0"), | ||
| depth: z.number().gt(0, "Depth must be greater than 0") | ||
| const BoundingBoxSchema = z.object({ | ||
| max: z.tuple([ | ||
| z.number().positive(), | ||
| z.number().positive(), | ||
| z.number().positive() | ||
| ]).describe("Maximum corner in millimeters and defined in the local coordianate system"), | ||
|
|
||
| }).openapi({ | ||
| description: "The bounding box of an element in millimeters.", | ||
| description: "Local bounding box aligned to element's own axes, origin at (0,0,0). Dimensions in millimeters." | ||
| }); | ||
|
|
||
| type BoundingBox = z.infer<typeof BoundingBoxSchema>; | ||
| export { BoundingBoxSchema, BoundingBox }; | ||
|
|
||
| export { | ||
| BoundingBoxSchema, | ||
| BoundingBox, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.