fix(handlers): return 499 on client cancel for get-server endpoints#1401
Open
piyushbag wants to merge 1 commit into
Open
fix(handlers): return 499 on client cancel for get-server endpoints#1401piyushbag wants to merge 1 commit into
piyushbag wants to merge 1 commit into
Conversation
Extend the ListServersError pattern from modelcontextprotocol#1335 to get-server-version and get-server-versions so benign client disconnects no longer log as 500s or trigger huma superfluous WriteHeader warnings. Fixes modelcontextprotocol#1323
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListServersErrorpattern to the get-server-version and get-server-versions handlersWriteHeaderclientClosedRequestand add unit tests for the new helpersFixes #1323 (handler-side scope; CDN/RPS follow-up tracked separately on the issue)
Problem
#1335 fixed cancellation handling for
GET /v0/serversonly. rdimitrov noted that PR only partially addressed #1323. The get-server-version and get-server-versions handlers still logged benign cancellations at error level and returned 500, which can trigger humasuperfluous response.WriteHeaderwarnings.Test plan
go test ./internal/api/handlers/v0/... -run 'ListServersError|GetServerDetailsError|GetServerVersionsError'go test -race ./internal/api/handlers/v0/... -run 'ListServersError|GetServerDetailsError|GetServerVersionsError'go vet ./internal/api/handlers/v0/...