feat(SEP-973): add support for icons and websiteUrl across relevant types#432
Merged
alexhancock merged 1 commit intomainfrom Sep 11, 2025
Merged
feat(SEP-973): add support for icons and websiteUrl across relevant types#432alexhancock merged 1 commit intomainfrom
alexhancock merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements SEP-973 support by adding icon and website URL capabilities across the MCP Rust SDK types. It extends the existing data models to support visual representation and documentation linking for servers, resources, tools, and prompts.
Key changes:
- Adds
Iconstruct for standardized icon representation with multiple format support - Extends
Implementationtype withiconsandwebsite_urlfields for server metadata - Adds icon support to
Tool,Resource, andPrompttypes for individual component branding
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rmcp/src/model.rs | Introduces Icon struct and extends Implementation with icons/website_url fields |
| crates/rmcp/src/model/tool.rs | Adds icons field to Tool struct |
| crates/rmcp/src/model/resource.rs | Adds icons field to RawResource struct |
| crates/rmcp/src/model/prompt.rs | Adds icons field to Prompt struct |
| examples/servers/src/sampling_stdio.rs | Updates example to include icons field |
| examples/clients/ | Updates client examples with new Implementation fields |
| crates/rmcp-macros/ | Updates proc macros to support icons in tool/prompt attributes |
| test files | Updates JSON schemas and test files to reflect new fields |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jokemanfire
approved these changes
Sep 11, 2025
This was referenced Sep 11, 2025
Merged
Closed
takumi-earth
pushed a commit
to earthlings-dev/rmcp
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Implementing support for SEP-973 as requested in #417
Adds
How Has This Been Tested?
Will also
Breaking Changes
N/A
Types of changes
Checklist