Skip to content

feat: deprecate roots/sampling/logging types (SEP-2577)#923

Open
DaleSeo wants to merge 1 commit into
mainfrom
feat/sep-2577-deprecate-model-types
Open

feat: deprecate roots/sampling/logging types (SEP-2577)#923
DaleSeo wants to merge 1 commit into
mainfrom
feat/sep-2577-deprecate-model-types

Conversation

@DaleSeo

@DaleSeo DaleSeo commented Jun 23, 2026

Copy link
Copy Markdown
Member

Closes #881

Motivation and Context

SEP-2577 deprecates the Roots, Sampling, and Logging features as of the 2026-07-28 spec. PR #881 already landed the SDK side of this for the service methods and the capability structs/builders, but it did not annotate the corresponding model types, even though the spec's schema reference marks all of them @deprecated.

This PR closes that gap so downstream users get consistent deprecation warnings for the whole surface for the following types:

  • Sampling: CreateMessageRequest, CreateMessageRequestParams, CreateMessageResult, SamplingMessage, SamplingMessageContent, ToolUseContent, ToolResultContent, ModelPreferences, ModelHint, ToolChoice
  • Roots: ListRootsRequest, ListRootsResult, Root
  • Logging: LoggingMessageNotification, LoggingMessageNotificationParams, LoggingLevel, SetLevelRequest, SetLevelRequestParams

How Has This Been Tested?

The message-schema snapshots were regenerated.

Breaking Changes

No. #[deprecated] is advisory only

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@github-actions github-actions Bot added T-test Testing related changes T-config Configuration file changes T-core Core library changes T-handler Handler implementation changes T-model Model/data structure changes T-service Service layer changes labels Jun 23, 2026
@DaleSeo DaleSeo changed the title feat: deprecate roots/sampling/logging types feat: deprecate roots/sampling/logging types (SEP-2577) Jun 23, 2026
@DaleSeo DaleSeo self-assigned this Jun 23, 2026
@DaleSeo DaleSeo marked this pull request as ready for review June 23, 2026 22:05
@DaleSeo DaleSeo requested a review from a team as a code owner June 23, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2026-07-28 T-config Configuration file changes T-core Core library changes T-handler Handler implementation changes T-model Model/data structure changes T-service Service layer changes T-test Testing related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement SEP-2577: Deprecate Roots, Sampling, and Logging

1 participant