Fix *page-name* to *page-index* conversion#107
Open
swaldhoer wants to merge 3 commits into
Open
Conversation
Author
|
@modelmat would it be possible to receive some feedback on the approach? |
Author
|
I have added 36720f9 which should create backwards compatibility with the the version that is currently used in testing (20.6.2). This is needed as older drawio-versions create slightly differently sized images. I am a bit confused why the tests for versions <= 27.0.2 pass at all, as the index in the *.rst files are all 1-based, but the the older drawio versions expect 0-based page index input. I would expect that all test cases that rely on the directive matching Anyhow, I will look into this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open point: What to do with older drawio versions? Should this be detected at runtime and then go back to 0-based indexing?
Issues: