Skip to content

Fix *page-name* to *page-index* conversion#107

Open
swaldhoer wants to merge 3 commits into
modelmat:mainfrom
swaldhoer:fix/page-name
Open

Fix *page-name* to *page-index* conversion#107
swaldhoer wants to merge 3 commits into
modelmat:mainfrom
swaldhoer:fix/page-name

Conversation

@swaldhoer

Copy link
Copy Markdown
  • Fix page-name to page-index conversion as needed since drawio 27.0.2
  • Add Windows CI tests

Open point: What to do with older drawio versions? Should this be detected at runtime and then go back to 0-based indexing?

Issues:

@swaldhoer

Copy link
Copy Markdown
Author

@modelmat would it be possible to receive some feedback on the approach?

@swaldhoer

swaldhoer commented Nov 20, 2025

Copy link
Copy Markdown
Author

I have added 36720f9 which should create backwards compatibility with the the version that is currently used in testing (20.6.2). This is needed as older drawio-versions create slightly differently sized images.

I am a bit confused why the tests for versions <= 27.0.2 pass at all, as the index in the *.rst files are all 1-based, but the the older drawio versions expect 0-based page index input. I would expect that all test cases that rely on the directive matching :page-(index|name): only pass for 27.0.2 or later.

Anyhow, I will look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

page-name maps to wrong diagrams with current drawio versions Tests only run on Linux

1 participant