Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the cookbook examples and their accompanying documentation by simplifying the training configuration and updating key components. It removes a redundant Megatron-related flag, ensuring consistent application of the linear learning rate scheduler. Additionally, the optimizer is updated to AdamW, and model references and team names are refreshed across both English and Chinese documentation to align with current practices and model versions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the cookbook examples by removing the use_megatron flag and its associated conditional logic. This simplifies the code, making the learning rate scheduler application unconditional. The documentation in both English and Chinese has been updated accordingly, also switching the example model to Qwen3.5-4B and the optimizer from Adam to the more modern AdamW. The changes are consistent and improve the clarity of the examples. I have one minor suggestion to update a comment that became misleading after the refactoring.
PR type
PR information
Write the detail information belongs to this PR.
Experiment results
Paste your experiment result here(if needed).