Skip to content

fix(viewer): restore mobile drawer in embedded WebKit #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benvinegar merged 1 commit into from
Jun 27, 2026
+53 −2
Merged

fix(viewer): restore mobile drawer in embedded WebKit #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/mobile-drawer-webkit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"sideshow": patch
---

Fix the mobile sessions drawer in embedded WebKit viewers so the menu button
opens the session list reliably.
43 changes: 43 additions & 0 deletions e2e/embed-main-slot.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,21 @@ const embedHtml = (sessionId: string) => `<!doctype html>
});
</script></body></html>`;

const fullEmbedHtml = (sessionId: string) => `<!doctype html>
<html><head><meta charset="utf-8"><style>html,body{margin:0;height:100%}#m{position:fixed;inset:0}</style></head>
<body><div id="m"></div>
<script type="module">
import { mountViewer } from "/__embed/engine.js";
mountViewer(document.getElementById("m"), {
basePath: "",
router: {
get: () => ({ sessionId: ${JSON.stringify(sessionId)} }),
navigate() {},
subscribe() { return () => {}; },
},
});
</script></body></html>`;

test("embedded engine: ss:main slot takes over the main pane while the sidebar stays", async ({
page,
server,
Expand Down Expand Up @@ -72,3 +87,31 @@ test("embedded engine: ss:main slot takes over the main pane while the sidebar s
// mechanics — but is not displayed, so the host pane is what the user sees.
await expect(page.locator("#stream")).toBeHidden();
});

test("embedded engine: mobile menu opens the session drawer", async ({ page, server }) => {
const surface = await publish(
server.url,
{ html: "<p>embedded mobile card</p>", title: "Embedded mobile", agent: "e2e" },
"",
);

page.on("pageerror", (e) => console.error("[pageerror]", e.message));
page.on("console", (m) => m.type() === "error" && console.error("[console]", m.text()));

await page.route("**/__embedtest-mobile", (route) =>
route.fulfill({ contentType: "text/html", body: fullEmbedHtml(surface.sessionId) }),
);
await page.route("**/__embed/**", (route) => {
const name = new URL(route.request().url()).pathname.replace("/__embed/", "");
route.fulfill({ contentType: contentType(name), body: readFileSync(`${embedDir}/${name}`) });
});

await page.setViewportSize({ width: 393, height: 852 });
await page.goto(`${server.url}/__embedtest-mobile`);

await expect(page.locator(".card:not(#whatsNew)")).toBeVisible();
await expect(page.locator("aside")).not.toBeInViewport();

await page.locator("#menuBtn").click();
await expect(page.locator("aside")).toBeInViewport();
});
6 changes: 4 additions & 2 deletions viewer/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,7 +1168,8 @@ iframe {
.aside-foot {
padding-bottom: calc(12px + env(safe-area-inset-bottom, 0px));
}
:is(body.nav-open, :host(.nav-open)) aside {
body.nav-open aside,
:host(.nav-open) aside {
transform: none;
box-shadow: 0 0 32px rgba(0, 0, 0, 0.25);
}
Expand All @@ -1182,7 +1183,8 @@ iframe {
pointer-events: none;
transition: opacity 220ms var(--ease-drawer);
}
:is(body.nav-open, :host(.nav-open)) #scrim {
body.nav-open #scrim,
:host(.nav-open) #scrim {
opacity: 1;
pointer-events: auto;
}
Expand Down
Loading