feat(viewer): minimal icons for card open/delete actions#36
Merged
Conversation
Replace the text "open ↗" / "delete" card actions with inlined Lucide icons (external-link and trash-2), a square icon hit area, and a red delete-on-hover via a new --danger token. Icons are inlined (no new dependency) so they inherit currentColor and the CSS-driven size. The `.act.open`/`.act.del` classes and the hover/focus reveal are unchanged, so existing behavior and tests hold. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The icons are subtle enough that they don't need the hover/focus reveal the text actions used; show them at rest so the open/delete affordances are always discoverable. Text actions (e.g. the release-notes "dismiss") keep the reveal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the text "open ↗" / "delete" actions on each surface card for minimal Lucide icons —
external-linkandtrash-2.viewer/src/icons.tsx), no new dependency — they inheritcurrentColorand a CSS-driven size, so they match the existing muted-on-hover chrome.--dangertheme token (light + dark)..act.open/.act.delclasses and the hover/focus reveal are unchanged, so existing behavior and the e2e action-visibility test still hold..act.icon.delso the text "dismiss" button in the release-notes card is untouched.Looks like
Light (default / delete-hover) and dark — actions appear on card hover as before:
Verified with screenshots in both color schemes.
Validation
.act.openvisibility check🤖 Generated with Claude Code