Week 2 Homework#13
Conversation
bhague1281
left a comment
bhague1281
left a comment
There was a problem hiding this comment.
Excellent job! You're doing very well with components and did some great styling with flexbox. I made a couple notes about your ArticleItem test that can help you get those tests working. Feel free to resubmit that if you want the extra couple points on the assignment.
| text-align: left; | ||
| display: block; | ||
| margin-left: 10px; | ||
| font-family: medium-content-sans-serif-font,-apple-system,BlinkMacSystemFont,"Segoe UI",Roboto,Oxygen,Ubuntu,Cantarell,"Open Sans","Helvetica Neue",sans-serif; |
There was a problem hiding this comment.
While you didn't have to use the exact font-family used on Medium, I like that you went to their site and saw how they were implementing their CSS. It's a great way to learn new styling methods and tricks 👍
| import React, { Component } from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| class PostDate extends Component { |
There was a problem hiding this comment.
Great job using modular components! Really important, especially with this PostDate component that gets a little tricky when it comes to rendering the date.
| class CreativityPage extends Component { | ||
|
|
||
| render() { | ||
| /* don't forget idx*/ |
| }); | ||
| describe('ArticleItem component', () => { | ||
| it('should render', () => { | ||
| const component = ReactTestRenderer.create(<ArticleItem />); |
There was a problem hiding this comment.
To get this test to pass, you'll want to pass in some fake data for the articleMetaData prop. Also, make sure to save the snapshot to git so that other developers can compare your test results.
2 participants
Caitlyn Chung week 2 hmwk submission