Week #2 homework#17
Open
cirept wants to merge 5 commits into
Open
Conversation
Finished styles, cards, and extra credit.
Finished PRoblems
added smoke tests and default prop values
added tests
irenab1
approved these changes
May 14, 2018
| * @param {object} item - The article object in the array | ||
| */ | ||
| const listItems = YourArticles.map((item, ind) => { | ||
| const { link, image, description, title, author, postedDate, minutesToRead } = item; |
There was a problem hiding this comment.
I wouldn't destructure the properties here, but rather pass the whole {item} as a prop to Card component. This way the component is responsible for its own internals
| @@ -0,0 +1,28 @@ | |||
| import React,{Component} from 'react'; | |||
There was a problem hiding this comment.
I'm not sure whether there's enough functionality and re-usability there to justify a separate component for Summary and Image
Author
There was a problem hiding this comment.
I kind of went down the rabbit hole on this one. I just kept breaking things down until I couldn't anymore. >.< Lesson learned. =]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 2 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.
3
complete
n/a