Week 2 HW Submission - Pavel Trekell#2
Conversation
| <link rel="manifest" href="%PUBLIC_URL%/manifest.json"> | ||
| <link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico"> | ||
| <link href="https://fonts.googleapis.com/css?family=Roboto" rel="stylesheet"> | ||
| <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.1.0/css/bootstrap.min.css" integrity="sha384-9gVQ4dYFwwWSjIDZnLEWnxCjeSWFphJiwGPXr1jddIhOegiu1FwO5qRGvFXOdJZ4" crossorigin="anonymous"> |
There was a problem hiding this comment.
I'll allow it 😉 It's nice to have the grid
| item: PropTypes.object.isRequired | ||
| } | ||
|
|
||
| export default BodyText; No newline at end of file |
There was a problem hiding this comment.
Great job with this component, using functional components + composing the component with the goToAddress function.
| @@ -0,0 +1,40 @@ | |||
| .nopadding { | |||
| padding: 0 !important; | |||
There was a problem hiding this comment.
For future reference, using !important is rarely a good practice in CSS. For this assignment, it's doable. But in larger projects, it can cause unexpected behaviors and bugs. An alternative to using !important is to be more specific with your selectors.
|
|
||
|
|
||
| render() { | ||
| if (this.props.lnBreak % 2) { |
There was a problem hiding this comment.
Clever, I like this. While you can also alternate styling with the :nth-child pseudo-selector. Either way works (I think developers making UIs that need to resize often tend to favor your method)
|
|
||
| it('should render <UserBadge /> element', ()=> { | ||
| expect(wrapper.find(UserBadge)).toHaveLength(1); | ||
| }); |
There was a problem hiding this comment.
Great job with going out and learning + incorporating Enzyme with your tests. I'll be making a video on this soon 😄
2 participants
Week 2 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.