Skip to content

adding snapshots and src files#20

Open
wolt0055 wants to merge 1 commit into
modern-web-application-uw18:masterfrom
wolt0055:master
Open

adding snapshots and src files#20
wolt0055 wants to merge 1 commit into
modern-web-application-uw18:masterfrom
wolt0055:master

Conversation

@wolt0055

Copy link
Copy Markdown

Week 2 HW Submission

Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.

  • Comfort rating on this assignment (1-5): 3
  • Completion rating on this assignment (complete/incomplete): mostly complete
  • Github handles of code I've reviewed: ?

Comment thread src/Author.js
@@ -0,0 +1,17 @@
import React from 'react';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this file and Title.js s.b. removed as unused

Comment thread src/MissedCard.js
@@ -0,0 +1,38 @@
import React from 'react';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Card and MissedCard components are very similar, and the difference between the two could be taken care of with styling. Not sure this justifies them being separate components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants