Assignemnt week 2#3
Open
raymondfrenchmore wants to merge 4 commits into
Open
Conversation
bhague1281
requested changes
May 9, 2018
bhague1281
left a comment
bhague1281
left a comment
Contributor
There was a problem hiding this comment.
Great use of components, but please do your own styling work. Even if it doesn't look exactly like Medium (that's ok). Also, try writing a test for your Story component.
| --> | ||
| <link rel="manifest" href="%PUBLIC_URL%/manifest.json"> | ||
| <link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico"> | ||
| <link rel="stylesheet" type="text/css" href="https://cdn-static-1.medium.com/_/fp/css/main-branding-base.X-Nw8EZw3j7tl3MaFDQL1g.css"> |
Contributor
There was a problem hiding this comment.
While this takes care of the styling, you pretty much copied Medium's DOM layout and stylesheet. The intent of the assignment is to not copy the code, but to write your own. Try again without doing this.
| <header className="u-flex u-marginBottom25 u-borderBottomLighter"> | ||
| <span className="heading-title heading-title--lineHeightTight u-flex0 u-block u-paddingBottom20 u-borderBottomNormal u-marginBottomNegative1 u-uiDisplayBold u-fontSize20 u-textColorDarker u-xs-fontSize18">For you</span> | ||
| </header> | ||
| {articles.map((article, index) => |
Contributor
There was a problem hiding this comment.
Great job making components for each story!
| this.handleClick = this.handleClick.bind(this); | ||
| } | ||
|
|
||
| handleClick() |
Contributor
There was a problem hiding this comment.
Nice use of state for the bookmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Week 1 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.