Dale Sande - week 2 - homework assignment#5
Conversation
bhague1281
left a comment
bhague1281
left a comment
There was a problem hiding this comment.
Looks solid! Just need to add some tests for the components, either a "smoke test" similar to App.test.js or some snapshots.
| @@ -0,0 +1,48 @@ | |||
| /* http://meyerweb.com/eric/tools/css/reset/ | |||
There was a problem hiding this comment.
Like everything, this is also a npm module. You may or may not find it handy on future assignments https://www.npmjs.com/package/reset-css
| class Card extends Component { | ||
| render() { | ||
|
|
||
| // destructure title var from article object |
| <ByElement author={name} | ||
| image={this.props.article.author.image} | ||
| postedDate={new Date(postedDate).toLocaleString( | ||
| 'en-us', standardOptions |
There was a problem hiding this comment.
Did not know of these options you can pass into toLocaleString. Nice!
| </div> | ||
| <div className='by-element__author-data'> | ||
| <p>{this.props.author}</p> | ||
| <p>{this.props.postedDate} - 2 min read</p> |
There was a problem hiding this comment.
Not a big deal, but "2 min" is hardcoded here.
|
@bhague1281 I just looked over this grade and noticed that I had a 15 out of 25 for Not seeing any real feedback here that would illustrate why there was a 10pt deduction? Can you explain why? |
|
@blackfalcon This was either a mistake on my end or a result of the rubric being changed to give less emphasis on tests. But I adjusted the grade so it's 25/25 for modular components and 0/10 for tests. But same grade overall. |
2 participants
Week 2 HW Submission
Please fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.