Week 2 Assignment#8
Open
kaa-no wants to merge 1 commit into
Open
Conversation
bhague1281
reviewed
May 25, 2018
| import React from 'react'; | ||
| import ReactDOM from 'react-dom'; | ||
| import RentalCart from './RentalCart'; | ||
| import TestRenderer from 'react-test-renderer'; |
Contributor
There was a problem hiding this comment.
When installing third-party modules like react-test-renderer, make sure to use the --save flag so it's saved to package.json
| describe("RentalCart", () => { | ||
| it('renders without crashing', () => { | ||
| const div = document.createElement('div'); | ||
| ReactDOM.render(<RentalCart homesCart={homesCart()} cancelYourRent={() => {}} whatRentalTotal={() => { return 0; }} />, div); |
Contributor
There was a problem hiding this comment.
These functions are not defined. Instead, you'll want to pass some fake data via props.
| ReactDOM.unmountComponentAtNode(div); | ||
| }); | ||
|
|
||
| it('Should render component with list of rental cart info and total', () => { |
Contributor
There was a problem hiding this comment.
Nice job w/the snapshot tests
| whatRentalTotal = () => { | ||
| var costTotal = 0; | ||
| for (var i = 0; i < this.state.productsInCart.length; i++) { | ||
| costTotal = costTotal + this.state.productsInCart[i].payment.cost; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.