[MOOSE-354] FE: Group block left/right padding in editor#329
[MOOSE-354] FE: Group block left/right padding in editor#329GeoffDusome wants to merge 5 commits intomainfrom
Conversation
|
@dpellenwood @Vinsanity Do either of you know if, because this was an issue on learn.tri.be if I have to also make this update there, or do we port stuff back there? |
spadilha
left a comment
There was a problem hiding this comment.
🍏 Just double check if the changes in package-lock.json was intentional.
Every time I run |
ac061c8 to
ee44924
Compare
dpellenwood
left a comment
There was a problem hiding this comment.
@Vinsanity & @LayaTaal , Is this related to the discussion we had yesterday about padding on group blocks? If so, can we loop Geoff and Marina in on this convo before this gets merged?
This is related @dpellenwood. I think we should go over this all once more with design to align on a permanent solution that works for them. |
|
@dpellenwood @LayaTaal Did we land anywhere here after talking to design? Should I talk to DE? Last I heard from Marina she wanted all padding removed from these Group blocks by default, including top & bottom. |
|
Re-requested reviews from everyone here as the scope changed per slack here: https://tribe.slack.com/archives/C04N3SZ7QVD/p1777927175330039 |
What does this do/fix?
This change removes the extra padding that was applied to core Group blocks when using the theme’s color styles (White, Light, Dark, Brand).
style.pcss: Drops the--group-themed-default-paddingcustom property and the rule that added vertical padding plus root horizontal padding to full-width groups insidemain(the previous behavior aligned inner content with the global root padding).10-white,20-light,30-dark,40-brand): Removes thespacing.paddingentry that usedvar(--group-themed-default-padding), so themed groups no longer get that default padding from the style variation.CHANGELOG.md: Documents the update under[2026.03].Editors can still control spacing via the block’s own spacing controls; this only removes the automatic themed padding.
QA
Links to relevant issues
Screenshots/video:
Pull request checklist