fix: repair truncated .sln entry + add a minimal CI build check#217
Open
sbarsbars wants to merge 2 commits into
Open
fix: repair truncated .sln entry + add a minimal CI build check#217sbarsbars wants to merge 2 commits into
sbarsbars wants to merge 2 commits into
Conversation
Checks out with submodules (catches the fresh-clone 'project not found' pitfall documented in CLAUDE.md), restores and builds the solution in Release on every push and pull request to main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The project declaration on line 26 was cut mid-path (ends at
'PowerDocu.De'), which makes the solution unparseable for
dotnet restore/build (MSB5013). Its configuration rows survived
further down under {AFA444CF-CC6C-40B3-B4FE-6F627A3FF888}, so the
line is completed with that original GUID - no other changes.
Found by the very build check this PR adds, on its first run.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sbarsbars
changed the title
Author
|
Heads-up on the force of events here: the build check itself caught a real issue on its first run — main's PowerDocu.sln currently doesn't parse under plain dotnet CLI (truncated project line, details in the PR description). First commit fixes that, second adds the check; green run on my fork: https://github.com/sbarsbars/PowerDocu/actions/runs/29659993520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, small and related:
1. PowerDocu.sln repair. Line 26's project declaration for PowerDocu.DesktopFlowDocumenter is truncated mid-path on main (ends at 'PowerDocu.De'), which makes the solution unparseable for dotnet restore/build (MSB5013). Its configuration rows survived further down under {AFA444CF-CC6C-40B3-B4FE-6F627A3FF888}, so the line is completed with that original GUID — a one-line change, nothing else touched. (Visual Studio tolerates/heals this quietly, which is probably why it went unnoticed — plain dotnet CLI does not.)
2. A minimal build check (.github/workflows/build.yml): checkout with submodules: recursive (catches the fresh-clone 'project not found' pitfall documented in CLAUDE.md's Common Pitfalls), .NET 10, restore + build in Release on every push/PR to main.
The workflow found the .sln issue on its very first run — red before the fix, green after: https://github.com/sbarsbars/PowerDocu/actions/runs/29659993520 (same commits, run on my fork so you don't burn approval clicks on a red run).
Deliberately minimal — no tests (none exist yet to run), no packaging, one job. Happy to adjust the .NET version pin or triggers if you'd prefer different ones.