fix: return error instead of silent Ok in hot_reload_plugin#291
Merged
lijingrs merged 1 commit intomofa-org:mainfrom Feb 24, 2026
Merged
fix: return error instead of silent Ok in hot_reload_plugin#291lijingrs merged 1 commit intomofa-org:mainfrom
lijingrs merged 1 commit intomofa-org:mainfrom
Conversation
lijingrs
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
The current implementation of
hot_reload_pluginsilently returnsOk(vec![])without performing any action.This can mislead callers into assuming that the plugin was successfully reloaded.
This PR updates the method to return an explicit
AgentError, clearly indicating that plugin hot reloading is not yet implemented.🔗 Related Issues
Closes #287
🧠 Context
Returning
Ok(vec![])from an unimplemented API can lead to silent failures and undefined behavior from the caller’s perspective.It is better to return an explicit error until the feature is properly implemented, ensuring predictable and transparent API behavior.
🛠️ Changes
Ok(vec![])withErr(AgentError::Other(...))🧪 How you Tested
cargo build --workspace🧹 Checklist
Code Quality
cargo fmtruncargo clippypasses without warningsTesting
cargo testpasses locally without any errorDocumentation
PR Hygiene
main🧩 Additional Notes for Reviewers
This change intentionally avoids implementing the full hot reload logic.
It only corrects the misleading success behavior of the existing stub.