feat: add preview-block for better placing preview.css#1
Open
mariolorenz wants to merge 1 commit intomoga-kit:masterfrom
Open
feat: add preview-block for better placing preview.css#1mariolorenz wants to merge 1 commit intomoga-kit:masterfrom
mariolorenz wants to merge 1 commit intomoga-kit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vanilla-thunder : Hello Marat i´ve a pull-request in the moga-theme to add an maintenance-task
During review the theme-repo, I saw that you include a preview.css in the Moga theme. The construct is only needed if the moga module is used. That's why I added a block to the theme that can be overwritten by your module.
The new "base_style_overload" block is deliberately placed in the "base_style" block so that other modules can continue to use the "base_style" block. In the theme block "base_style_overload" only the [{oxstyle include = "css / styles.min.css"}] is stored so that your preview.css can overwrite it.