chore(deps): bump NetDid.* → 2.3.0, NetCrypto → 1.2.0 (v1.1.0)#17
Merged
Conversation
…v1.1.0) Foundation dependency bump for downstream convergence with net-wallet-sdk 0.2.0 (issue #16). NetDid.Core 2.3.0 requires NetCrypto 1.2.0, so the NetCrypto bump is the convergence, not an option — 1.1.0 would be an NU1605 downgrade. NetCid stays 1.6.0. Dependency-only change, no public API delta: build is warnings-clean, the full suite (391 tests) is green, the default consumer closure stays Newtonsoft-free, and all three packages pass ApiCompat against the published 1.0.0 baseline with no breaking changes. Also fixes tools/check-api-compat.sh: Microsoft.DotNet.ApiCompat.Tool 10.0.301 takes the package to validate as a positional arg, not `--package <path>`. This path first executes now that 1.0.0 is a real baseline (it SKIP-ed before). Bumps CredentialsVersion to 1.1.0. Closes #16 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
moisesja
commented
Jul 14, 2026
moisesja
left a comment
Owner
Author
There was a problem hiding this comment.
Reviewed the diff (CHANGELOG.md, Directory.Build.props, Directory.Packages.props, tools/check-api-compat.sh, plus the checked-in tasks/todo-...md plan).
Overall: clean, well-scoped dependency-only bump. Single commit, no source/API changes, rationale for the NetCrypto 1.1.0→1.2.0 pin (required transitively by NetDid.Core 2.3.0, not optional) is correctly explained and matches how central package management is set up here. Changelog entry is thorough. Grepped the repo for stray references to the old pins (2.0.1, NetCrypto 1.1.0) outside the touched files — none found.
A couple of minor notes, nothing blocking:
- Scope: this PR bundles the version bump with an unrelated fix to
tools/check-api-compat.sh(positional vs.--packagearg). Justified here since it's the only way to actually exercise the ApiCompat gate for this bump (previously never ran, since 1.0.0 had no baseline), but worth calling out explicitly in case that's not intentional. - Directory.Packages.props comment: the reworded header comment has an awkward line break ("...issue #16). Not / every entry is referenced yet: the / later milestones...") — cosmetic only.
- I don't have a
dotnetSDK available in this review environment, so I could not independently reproduce the build/test/ApiCompat results claimed in the description — the twobuild + testchecks were stillin_progressas of this review. Please confirm they're green before merging.
No correctness or security concerns. Approving pending green CI.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Foundation dependency bump for downstream convergence with net-wallet-sdk 0.2.0 (closes #16), released as v1.1.0.
NetDid.Core/NetDid.Method.Key/NetDid.Extensions.DependencyInjection2.0.1 → 2.3.0NetCrypto1.1.0 → 1.2.0NetCidstays 1.6.0CredentialsVersion1.0.0 → 1.1.0Why this is a clean, dependency-only change
NetDid.Core 2.3.0transitively depends onNetCrypto 1.2.0, so pinning NetCrypto to 1.2.0 is required by the net-did bump (leaving it at 1.1.0 would be the downgrade).DataProofsDotnet.* 1.1.0wantsNetCrypto 1.1.0/NetCid 1.6.0— both satisfied. The whole graph converges on NetCrypto 1.2.0 / NetCid 1.6.0.did:key. The net-did 2.1→2.3 changes tightened the did:webvh update/deactivate driver, which this library does not exercise.Verification (mirrors the release gate)
dotnet build -c Release— 0 warnings (warnings-as-errors)dotnet test --filter "Category!=Conformance"— 391 tests, 0 failurestools/check-no-newtonsoft-closure.sh— default consumer closure Newtonsoft-free (resolved graph: NetCrypto 1.2.0, NetDid.* 2.3.0, NetCid 1.6.0)tools/check-api-compat.sh— all 3 packages vs published 1.0.0 baseline: no breaking changesAlso fixed
tools/check-api-compat.shpassed the package-to-validate as--package <path>, butMicrosoft.DotNet.ApiCompat.Tool10.0.301 takes it positionally. This gate had never actually run (1.0.0 was the first release → no baseline → SKIP), so the bug was latent; it would have failed this release. Now corrected and passing against the real 1.0.0 baseline.Note
packages.lock.jsonregeneration from the issue's acceptance list is N/A — this repo has no lock files and does not setRestorePackagesWithLockFile.🤖 Generated with Claude Code