fix: resolve security issues, deadlocks, and clean up dead code#21
Merged
Conversation
- Resolved command injection risks in PowerShellEngine and MainViewModel. - Fixed API key leak in GeminiProvider by using request headers. - Fixed potential deadlocks in stream reading in CommandRepair and PowerShellEngine. - Removed dead code (IColector, DiagnosticContext, unused commands/properties). - Added settings.json to .gitignore to prevent local key leakage. - Converted ChatMessages, Modulos, and Problemas collections to ObservableCollection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses the security, quality, and bug findings from the comprehensive repository audit.
Changes Implemented:
Security Fixes:
Bug & Robustness Fixes:
Performance & Cleanups: