Skip to content

feat(mojaloop/#3636): batching implementation for position prepare messages#968

Merged
oderayi merged 88 commits intomainfrom
feature/position-prepare-binnning
Dec 5, 2023
Merged

feat(mojaloop/#3636): batching implementation for position prepare messages#968
oderayi merged 88 commits intomainfrom
feature/position-prepare-binnning

Conversation

@vijayg10
Copy link
Copy Markdown
Contributor

@vijayg10 vijayg10 commented Sep 6, 2023

feat(mojaloop/#3636): batching implementation for position prepare messages - mojaloop/project#3636

  • Added prepare-batch handler for prepare messages
  • Updated metrics
  • Replaced uuidv4 with built-in randomUUID from crypto nodejs library
  • bulk-prepare messages are routed to non-batch prepare handler
  • Added tests (unit, integration)

@vijayg10 vijayg10 self-assigned this Sep 6, 2023
@vijayg10 vijayg10 changed the title feat: added skeleton and comments for prepare bin implementation feat: batching implementation for position prepare messages Sep 7, 2023
vijayg10 and others added 22 commits September 8, 2023 14:48
* feat: add position prepare bin logic

* edit

* lint

* dep

* chore: changes

* chore: commet

* lint

* chore: refactor

* chore: unit tests

* chore: change

* chore: comment

* chore: test

* chore: more test

* chore: test?

* chore: remove

* chore: rework domain logic

* chore: test

* fix: position calculation

* fix: position change data

* fix; prepare domain function

* chore: fix

---------

Co-authored-by: Vijay <vijaya.guthi@infitx.com>
* chore: add tests

* chore: unit

* sleep

* chore: clear

* chore: test

* enum

* fix: deadlock in tests

---------

Co-authored-by: Vijay <vijaya.guthi@infitx.com>
@oderayi oderayi changed the title feat: batching implementation for position prepare messages feat(mojaloop/#3636): batching implementation for position prepare messages Nov 16, 2023
Comment thread src/domain/position/binProcessor.js Outdated
@oderayi oderayi requested a review from elnyry-sam-k November 22, 2023 09:40
Comment thread src/handlers/positions/handlerBatch.js Outdated
Comment thread src/handlers/positions/handlerBatch.js Outdated
elnyry-sam-k
elnyry-sam-k previously approved these changes Dec 4, 2023
@elnyry-sam-k
Copy link
Copy Markdown
Member

Thanks @vijayg10 , @kleyow and @oderayi .. approved with two minor comments. Please merge after addressing those.

@oderayi oderayi merged commit 538616d into main Dec 5, 2023
@kleyow kleyow deleted the feature/position-prepare-binnning branch August 28, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants