chore: Bump intra-repo deps to v0.12.6 - #167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/mojatter/s2(and, for s2env, s3/gcs/azblob) require lines in the five replace-modules to v0.12.6.release.yamlinstalled Go percmd/s2-server/go.mod(1.25.8) instead ofgo.work(1.26). fix(ci): Point release workflow's Set up Go at go.work #166 fixes that; this PR re-cuts the release under v0.12.6.cmd/s2-serveris intentionally excluded here; it's bumped in a follow-up PR after the submodule tags are published (see docs/releasing.md).Test plan
go vet ./...andgo test ./...at the workspace rootgo test ./...in s3, gcs, azblob, s2env, server, cmd/s2-serverGOWORK=off go build .in cmd/s2-server (against the previous published version)GOWORK=off go build ./...in serverGOWORK=off go test -tags integtest -cin s3