Add artifact classifier to ChangeRocorderXML

[ggkochanski]

When two dependencies differ by the classifier only then they appear twice in file version-changes.xml but you cannot distinguish which is which.

The general idea is to add the artifact's classifier attribute to node /updates/dependencyUpdate when is set:

        DependencyVersionChange change = (DependencyVersionChange) changeRecord.getVersionChange();
        update.setAttribute("groupId", change.getGroupId());
        update.setAttribute("artifactId", change.getArtifactId());
        if(change.getClassifier() != null) {
            update.setAttribute("classifier", change.getClassifier());
        }

[andrzejj0]

There's currently #1284 open which is going to overhaul the change recorder. I could include your change there or maybe you could wait until it's merged in.

FWIW, you'd also need to update the xsd and the documentation.

[ggkochanski]

@andrzejj0 please go ahead, you know the structure better then me 😅

The classifier makes only sens for dependencies, so sth like this should be sufficient:

class DefaultDependencyVersionChange {
...
        public Builder withDependency(Dependency dependency) {
            groupId = dependency.getGroupId();
            artifactId = dependency.getArtifactId();
+            classifier = dependency.getClassifier();
            oldVersion = dependency.getVersion();
            return this;
        }

        public Builder withArtifact(Artifact artifact) {
            groupId = artifact.getGroupId();
            artifactId = artifact.getArtifactId();
  +          classifier = artifact.getClassifier();
            oldVersion = artifact.getVersion();
            return this;
        }

[andrzejj0]

Yes, it's generally a good idea. A classifier could definitely be added. I'm thinking of maybe making it optional and only providing it if it differs from the standard.

Same goes for type, I guess. It gets used a lot sometimes.

I would not stack too much changes into that one PR so that we don't overwhelm Sławek who needs to review all that.

[ggkochanski]

code format fixed, schema updated, integration test added

and waiting for events to unfold 😊