Skip to content

docs: clarify when screenshots belong in pull requests #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alvst wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: clarify when screenshots belong in pull requests #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ open packaging/Pesty.app
- Keep it dependency-free. Prefer system frameworks (AppKit, SwiftUI, Carbon, ServiceManagement).
- Match the existing style. Small, focused changes; no unrelated refactors in the same PR.
- Test on both Apple Silicon and Intel where it matters (the release is universal).
- UI changes: include a before/after screenshot of the strip.
- Screenshots: add them when a user-facing UI change needs visual context or when they make review easier; they are not required for every change.

## Pull requests

1. Fork and branch from `main`.
2. Make your change; ensure `swift build` is clean (no warnings).
3. Open a PR with a clear description and screenshots for UI changes.
3. Open a PR with a clear description and any screenshots that are useful for review.

## Good first issues

Expand Down