#942 filter out link local address broadcasting#141
Conversation
There was a problem hiding this comment.
Thanks for the PR.
Please don't use hard coded IP address (i.e. ' var LINK_LOCAL_ADDRESS_PREFIX = '169.254.';').
Instead of this, please use CONFIG_FILE defined in
Line 42 in 766ace8
Please get the filtering IP address from CONFIG_FILE and use it if the address is defined.
The config file is simple json file named monaca_config.json in /YourHome/.cordova/monaca_config.json.
For example, monaca_config.json should be like
{
"http_proxy": "",
"update_check_time": "1519962109517"
"ignore_broadcast": ["111.222.333.444", "123.456.789.012" ]
}
|
It is an implementation scoped thing, rather than a configuration one. The link-local address range is listed in an official RFC, https://tools.ietf.org/html/rfc3927 . I can make it more generic, but it might be better to put it in the |
https://redmine.monaca.io/issues/942